Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed string subID bug #1291

Merged
merged 8 commits into from
Aug 24, 2024
Merged

fixed string subID bug #1291

merged 8 commits into from
Aug 24, 2024

Conversation

Aaronearlerichardson
Copy link
Contributor

@Aaronearlerichardson Aaronearlerichardson commented Aug 13, 2024

PR Description

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

welcome bot commented Aug 13, 2024

Hello! 👋 Thanks for opening your first pull request here!
Please read the contributor guide, and please follow the steps outlined in the "Instructions for first-time contributors" section therein. ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@Aaronearlerichardson
Copy link
Contributor Author

will fix #1290

@sappelhoff
Copy link
Member

Thanks @Aaronearlerichardson! Could you please modify one of our tests to cover this case?

Also, please feel free to add yourself to the list of authors, and add a changelog entry: https://github.com/mne-tools/mne-bids/blob/main/CONTRIBUTING.md#instructions-for-first-time-contributors

@sappelhoff sappelhoff added this to the 0.16 milestone Aug 14, 2024
@sappelhoff
Copy link
Member

@Aaronearlerichardson please let me know if you intend to work on the final points I mentioned in my comment above, and what your expected timeline would be. If not, somebody else could perhaps take over (as long as you supply a few of your details to list you in the authors lists)

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (87eea28) to head (1817b34).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1291      +/-   ##
==========================================
- Coverage   97.61%   97.46%   -0.16%     
==========================================
  Files          40       40              
  Lines        8685     8780      +95     
==========================================
+ Hits         8478     8557      +79     
- Misses        207      223      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aaronearlerichardson
Copy link
Contributor Author

@sappelhoff hope this covers it

@sappelhoff sappelhoff enabled auto-merge (squash) August 24, 2024 11:18
@sappelhoff sappelhoff merged commit a4759bf into mne-tools:main Aug 24, 2024
23 of 24 checks passed
Copy link

welcome bot commented Aug 24, 2024

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

@sappelhoff
Copy link
Member

Thanks a lot @Aaronearlerichardson :-)

@sappelhoff hope this covers it

I added a few more commits, but thanks for the start and the contribution in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create new participants.tsv entry when subject ID is non numeric
2 participants